Add ability to disable automatic linking for Github-Style shortcodes #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @HEIGE-PCloud on Vercel. @HEIGE-PCloud first needs to authorize it. |
…(backwards-compatible, default is still true)
AutomationD
force-pushed
the
feature/add-ability-to-disable-image-linking
branch
from
089be62
to
3333179
Compare
|
@HEIGE-PCloud can you please review? Thank you! |
CXwudi
reviewed
Nov 3, 2023
| @@ -182,6 +182,9 @@ cacheRemoteImages = false | |||
| # 是否启用阅读时间估计 | |||
| enableReadingTime = true | |||
| # Display a message at the beginning of an article to warn the reader that its content might be outdated. | |||
| # Whether to enable images to be linked to themselves by default | |||
There was a problem hiding this comment.
Make sure to add a Chinese translation of the English description, you can use any translator like DeepL
CXwudi
reviewed
Nov 3, 2023
| @@ -182,6 +182,9 @@ cacheRemoteImages = false | |||
| # 是否启用阅读时间估计 | |||
| enableReadingTime = true | |||
| # Display a message at the beginning of an article to warn the reader that its content might be outdated. | |||
There was a problem hiding this comment.
This comment at line 184 should stay together with the comment at line 188 as it is the English translation of that Chinese description
|
I believe the link element there is mainly for the light gallery support. The right way to do it might be to disable the links when light gallery is not enabled. |
|
Fixed in 9e7d099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098