Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple silicon compatibility #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sintendo
Copy link

  • Upgrade catch to v2.13.10 for Apple silicon support
  • Add Frida Gum static library for macOS ARM64

Bram Speeckaert added 2 commits October 17, 2022 11:56
The old version did not have support for Apple silicon.
@MichielDerhaeg
Copy link
Contributor

Which version of gum was used? We have to make sure the versions are in sync as they use the same headers.
Can you check if setting up CI for Apple Silicon is easy?

@@ -5,11 +5,15 @@ if(NOT WIN32)
endif()

if (APPLE)
set(ARCHITECTURE_PATH x86_64 )
if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "arm64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use CMAKE_SYSTEM_PROCESSOR. When cross-compiling, the target architecture can be different than the host architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants