Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Bugfix/fix move errors #477

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Sep 3, 2021

  1. Don't log so many exceptions.

    Some errors are fatal, so we should log the exception.
    Other errors we will try to handle and try again, in such a case
    just log a warning unless it is the final attempt. This means
    successful retries will not result in an exception being logged.
    JonathanWylie committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    f731e9d View commit details
    Browse the repository at this point in the history
  2. Fix detecting when it is the last attempt

    - SlotNotCoveredError, was re-raising the exception one attempt too soon.
    - Similarly log_exception
    JonathanWylie committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6b4dbf3 View commit details
    Browse the repository at this point in the history
  3. Initialise the node manager correctly

    populate_startup_nodes is meant to put all the known nodes in the startup nodes list,
    but when it was called, the nodes list it was using (self.nodes) is not populated yet.
    So populate startup nodes after initialising self.nodes,
    otherwise when we choose a random connection (which is chosen from startup nodes),
    the options are too limited. Often a user will specify a single startup node at the beginning.
    JonathanWylie committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    7c87352 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Make it easier to run the tests.

    Add a docker-compose.yml file configuring a redis cluster instance for running the tests against.
    JonathanWylie committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    dffbd52 View commit details
    Browse the repository at this point in the history