Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update base and development dependencies #8

Merged
merged 4 commits into from
May 30, 2024

Conversation

egparedes
Copy link
Collaborator

@egparedes egparedes commented May 29, 2024

Add:

  • Required and optional project dependencies to pyproject.toml.
  • Pre-commit check to forbid incorrect capitalizations of DaCe and JaCe.

Change:

  • Bump versions of development tools in pre-commit config.
  • Ignore typing errors due to missing typing hints in dace and jax.

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once DaCe 0.16 is released (it should be any moment) we should update, there is one small feature that we use.
However, now MyPy flags a lot of other stuff.

hooks:
- id: mypy
files: src|tests
args: [--no-install-types]
additional_dependencies:
- pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add pytest again, it now complains about that in the test.

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is still the pytest issue that was not there before.
  • We should disable the TCH003 rule.

@philip-paul-mueller
Copy link
Contributor

  • There is still the jaxlib error:
    /home/quint_essent/.cache/pre-commit/repoewkddxzp/py_env-python3.12/lib/python3.12/site-packages/jaxlib/ducc_fft.py:20:1: error: Cannot find implementation or library stub for module named "jaxlib.cpu" [import-not-found]
  • There is still the pytest error:
    tests/general_tests/test_package.py:12:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]
  • There is still the untyped dace error:
    src/jace/stages.py:41:1: error: Skipping analyzing "dace": module is installed, but missing library stubs or py.typed marker [import-untyped]

@philip-paul-mueller philip-paul-mueller dismissed their stale review May 30, 2024 06:46

Pushed the wrong button, silly I know

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egparedes egparedes merged commit e0f147a into GridTools:main May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants