Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modular Calling #28

Merged

Conversation

philip-paul-mueller
Copy link
Contributor

This commit modifies how calling an compiled SDFG works.
Instead of the function CompiledJaxprSDFG__call__ the process is split.
This allows an experienced user a more fine grained control to how the SDFG is called.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3be9f36). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage        ?   68.56%           
=======================================
  Files           ?       31           
  Lines           ?     1285           
  Branches        ?      261           
=======================================
  Hits            ?      881           
  Misses          ?      329           
  Partials        ?       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@philip-paul-mueller philip-paul-mueller merged commit e1e46ee into GridTools:main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants