Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes randomness and some issues #19

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixes randomness and some issues #19

wants to merge 8 commits into from

Conversation

kuvam
Copy link

@kuvam kuvam commented Feb 16, 2017

Minor edit that fixes a small bug: if the target of an assassin card unsuccessfully called a bluff and lost their last card that way, extraneous messages were sent as reported in #16 (and in the beta feedback group).

Untested since I can't run it without knowing how the db is set up.

@kuvam
Copy link
Author

kuvam commented Feb 16, 2017

Also fixes this unreported issue: missing "<player> has chosen to call a bluff" message when the bluff is unsuccessful and the player who called it loses their last card.

@kuvam kuvam changed the title Fixes issue #16 Fixes randomness and some issues Feb 21, 2017
@kuvam
Copy link
Author

kuvam commented Feb 21, 2017

  • Replaces weird biased Shuffle() function, which used to only be able to return a certain subset of all possible orderings, and even those unequally weighted.
  • Truncates overly-long "Checks cards on turn" decimal, adds win % to player stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants