Improve Logging for Unread Packet Data #2698
Open
+125
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log initial data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves the logging for unread packet data
Implementation Details
Add a method to iterate through a classes fields to find valid data codes, then put the name of that field into a Int2String map.
the method also allows for addons to register their id classes as well
if the id is not registered,
"Unknown_DataCode:#"is returned instead, with#being the id.Adds a static method to ISyncedTileEntity to handle unread packet logging
log unread packet data at the MTE level for covers
Outcome
Logging now tells us exactly which ID was called instead of just its assigned int