Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q7 online #445

Merged
merged 39 commits into from
Jan 24, 2025
Merged

Q7 online #445

merged 39 commits into from
Jan 24, 2025

Conversation

teuben
Copy link
Collaborator

@teuben teuben commented Jan 8, 2025

This PR implements the equivalent of the GBTIDL routines "online" and "offline".

  1. sdf = GBTOnline()

    Monitors new data in $SDFITS_DATA, $DYSH_DATA/sdfits or /home/sdfits (in that order).
    Any of the "sdf" functions "summary()", "gettp()" etc.
    will check if new data have arrived and refresh the "sdf" object automatically
    (user is informed if that happens).

  2. sdf = GBTOnline('foo')

    Monitor a specific project. Possibly an unusual mode, but this mode exists.

  3. sdf = GBTOffline('foo')

    Load a specific project, and is thus functionally similar to GBTFITSLoad('foo')

@mpound
Copy link
Collaborator

mpound commented Jan 22, 2025

You should add GBTOnline and GBTOffline to dysh/fits/init.py so they can be imported directly from dysh.fits as we do with GBTFITSLoad.
Arguably, dysh/shell/shell.py should also be updated, but I suggest that be made a separate enhancement issue for @tchamberlin after this branch is merged.

Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out on gb machines, works as expected except my comments about *args in GBTOnline/Offline, catcher for subbeamnod, and init.py. Fix those and I'll approve.

@teuben
Copy link
Collaborator Author

teuben commented Jan 23, 2025

reminding myself too: can't write the dunder init, but have to write with two backslashes up front __init__ and the rest is history

@mpound
Copy link
Collaborator

mpound commented Jan 23, 2025

reminding myself too: can't write the dunder init, but have to write with two backslashes up front init and the rest is history

gets me every time

Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I tried on on gb machine, works as expected.

@teuben
Copy link
Collaborator Author

teuben commented Jan 24, 2025

Need to keep an eye open now for performance (e.g. is there a longer and longer wait) as the file grows

@teuben teuben merged commit 1ab9cb9 into main Jan 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants