Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psuedo-class selector :text producing errors and incorrect results #50

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Mar 21, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  1. If doing ->is(':text') on a text node an error is produced.
  2. If doing ->find(':text') it won't match <input /> tags without a type (which are considered text inputs). See https://api.jquery.com/text-selector/

Issue Number: #49

What is the new behavior?

TBA

Does this introduce a breaking change?

  • Yes
  • No

TBA

Other information

Unit tests are written. Code to pass the tests still to be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant