Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Examples #36

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Refactor Examples #36

wants to merge 14 commits into from

Conversation

jakejackson1
Copy link
Member

Modernize and Refactor the examples included in the /examples/ directory.

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Many of the examples are outdated and/or broken.

What is the new behavior?

Organize each example into a subdirectory for easier browsing, refactor the code, fix up any broken code, make it easier to understand, and rename.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is a WIP. Once done, I'm considering migrating the examples into their own repo, so people can clone the repo, composer install, and then directly access each example to see what it does.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (86f1c77) to head (4c0100b).
Report is 3 commits behind head on main.

❗ Current head 4c0100b differs from pull request most recent head 7a9aeae. Consider uploading reports for the commit 7a9aeae to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #36   +/-   ##
=========================================
  Coverage     88.41%   88.41%           
  Complexity     1349     1349           
=========================================
  Files            26       26           
  Lines          3124     3124           
=========================================
  Hits           2762     2762           
  Misses          362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant