Merge pull request #140 from NeedleInAJayStack/fix/warnings

Fixes compiler warnings
GraphQLSwift · Mar 19, 2024 · 63c74fa · 63c74fa
2 parents 0fee9b5 + 40d176f
commit 63c74fa
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/Sources/GraphQL/Execution/Execute.swift b/Sources/GraphQL/Execution/Execute.swift
@@ -187,7 +187,7 @@ public struct ConcurrentDispatchFieldExecutionStrategy: QueryFieldExecutionStrat
             .mapValues { _ -> Future<Any>? in nil }
         var err: Error?
 
-        fields.forEach { field in
+        for field in fields {
             let fieldASTs = field.value
             let fieldKey = field.key
             let fieldPath = path.appending(fieldKey)

diff --git a/Sources/GraphQL/Type/Directives.swift b/Sources/GraphQL/Type/Directives.swift
@@ -1,3 +1,5 @@
+import OrderedCollections
+
 public enum DirectiveLocation: String, Encodable {
     // Operations
     case query = "QUERY"

diff --git a/Sources/GraphQL/Validation/Rules/Custom/NoDeprecatedCustomRule.swift b/Sources/GraphQL/Validation/Rules/Custom/NoDeprecatedCustomRule.swift
@@ -52,8 +52,6 @@ public func NoDeprecatedCustomRule(context: ValidationContext) -> Visitor {
                 }
             }
             if let node = node as? ObjectField {
-                let inputObjectDef = context.parentInputType as? GraphQLInputObjectType
-
                 if
                     let inputObjectDef = context.parentInputType as? GraphQLInputObjectType,
                     let inputFieldDef = inputObjectDef.fields[node.name.value],

diff --git a/Tests/GraphQLTests/FieldExecutionStrategyTests/FieldExecutionStrategyTests.swift b/Tests/GraphQLTests/FieldExecutionStrategyTests/FieldExecutionStrategyTests.swift
@@ -259,7 +259,7 @@ class FieldExecutionStrategyTests: XCTestCase {
         XCTAssertEqual(result.value.data, multiThrowsExpectedData)
         let resultErrors = result.value.errors
         XCTAssertEqual(resultErrors.count, multiThrowsExpectedErrors.count)
-        multiThrowsExpectedErrors.forEach { m in
+        for m in multiThrowsExpectedErrors {
             XCTAssertTrue(resultErrors.contains(m), "Expecting result errors to contain \(m)")
         }
         // XCTAssertEqualWithAccuracy(1.0, result.seconds, accuracy: 0.5)
@@ -308,7 +308,7 @@ class FieldExecutionStrategyTests: XCTestCase {
         XCTAssertEqual(result.value.data, multiThrowsExpectedData)
         let resultErrors = result.value.errors
         XCTAssertEqual(resultErrors.count, multiThrowsExpectedErrors.count)
-        multiThrowsExpectedErrors.forEach { m in
+        for m in multiThrowsExpectedErrors {
             XCTAssertTrue(resultErrors.contains(m), "Expecting result errors to contain \(m)")
         }
         // XCTAssertEqualWithAccuracy(0.1, result.seconds, accuracy: 0.25)