Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-service static_fields. Resolve #659. #908

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ryneeverett
Copy link
Collaborator

Add a static_fields option to Common Service Configuration Options. This
enables users to differ behavior of core UDA names (e.g., "description")
amongst services.

The tests fail because we're currently able to test db.synchronize using regular dicts as issues whereas in a real bugwarrior pull these are Issue instances. This PR is awaiting a much-needed refactor of db.synchronize which will break this monstrous function into more testable components.

Add a static_fields option to Common Service Configuration Options. This
enables users to differ behavior of core UDA names (e.g., "description")
amongst services.
@ryneeverett
Copy link
Collaborator Author

While restructuring db.synchronize would still be a nice step, I think a simpler architectural improvement which would also unblock this for testing purposes would be to make the Issue class private to the services subpackage which can return simple dicts instead. This not only makes testing easier but eliminates unnecessary coupling between services and db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant