Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kokoro v4 test #9658

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/compile-mac.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Cross-Compile skaffold on MacOS

# Triggers the workflow on push or pull request events
on: [push, pull_request]

permissions: read-all

concurrency:
group: build-${{ github.event.pull_request.number || github.ref }}-${{github.workflow}}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

jobs:

build:
name: Cross-Compile skaffold on MacOS
runs-on: macos-15-large
strategy:
matrix:
platforms: [linux-amd64, darwin-amd64, windows-amd64.exe, linux-arm64, darwin-arm64]
steps:

- name: Check out code into the Go module directory
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.23.4
id: go

- name: Setup Docker
uses: docker/setup-docker-action@v4
env:
LIMA_START_ARGS: --mount-writable

- name: Make and install Skaffold binary from current PR
run: |
make ./out/VERSION
make ./out/skaffold-${{ matrix.platforms }}
26 changes: 24 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
GOVERSION ?= 1.23.4
GOPATH ?= $(shell go env GOPATH)
GOBIN ?= $(or $(shell go env GOBIN),$(GOPATH)/bin)
GOOS ?= $(shell go env GOOS)
Expand Down Expand Up @@ -93,12 +94,33 @@ install: $(BUILD_DIR)/$(PROJECT)
.PHONY: cross
cross: $(foreach platform, $(SUPPORTED_PLATFORMS), $(BUILD_DIR)/$(PROJECT)-$(platform))

$(BUILD_DIR)/$(PROJECT)-%: $(EMBEDDED_FILES_CHECK) $(GO_FILES) $(BUILD_DIR)
.PHONY $(BUILD_DIR)/$(PROJECT)-%:
$(BUILD_DIR)/$(PROJECT)-%:
$(eval os = $(firstword $(subst -, ,$*)))
$(eval goarch = $(lastword $(subst -, ,$(subst .exe,,$*))))
$(eval image_platform = $(shell \
if [[ $(os) == "darwin" ]]; then \
echo darwin-arm64; \
elif [[ $(goarch) == "arm64" ]]; then \
echo arm; \
else \
echo main; \
fi \
))
@echo $(image_platform)
docker run --rm \
-v $(CURDIR):/skaffold \
-w /skaffold \
docker.elastic.co/beats-dev/golang-crossbuild:$(GOVERSION)-$(image_platform)-debian12 \
-p="$(os)/$(goarch)" \
--build-cmd="git config --global --add safe.directory /skaffold;make ./out/docker-skaffold-$(os)-$(goarch)"

$(BUILD_DIR)/docker-$(PROJECT)-%: $(EMBEDDED_FILES_CHECK) $(GO_FILES) $(BUILD_DIR)
$(eval os = $(firstword $(subst -, ,$*)))
$(eval arch = $(lastword $(subst -, ,$(subst .exe,,$*))))
$(eval ldflags = $(GO_LDFLAGS) $(patsubst %,-extldflags \"%\",$(LDFLAGS_$(os))))
$(eval tags = $(GO_BUILD_TAGS) $(GO_BUILD_TAGS_$(os)) $(GO_BUILD_TAGS_$(os)_$(arch)))
GOOS=$(os) GOARCH=$(arch) CGO_ENABLED=1 go build -mod="vendor" -tags "$(tags)" -ldflags "$(ldflags)" -o $@ ./cmd/skaffold
CGO_ENABLED=1 go build -mod="vendor" -tags "$(tags)" -ldflags "$(ldflags)" -o $@ ./cmd/skaffold
(cd `dirname $@`; shasum -a 256 `basename $@`) | tee [email protected]
file $@ || true

Expand Down
Loading