feat: add config option kaniko.imagePullSecret #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherges
commented
Nov 24, 2023
| @@ -1419,6 +1419,9 @@ type KanikoArtifact struct { | |||
| // Defaults to the latest released version of `gcr.io/kaniko-project/executor`. | |||
| Image string `yaml:"image,omitempty"` | |||
|
|
|||
| // ImagePullSecret is the name of the Kubernetes secret for pulling kaniko image and kaniko init image from a private registry | |||
| ImagePullSecret string `yaml:"imagePullSecret,omitempty"` | |||
There was a problem hiding this comment.
Hello skaffold maintainers, is someone available to help? I was instructed to create a separate pull request for the config change. It is only the 2 lines above. How are the unit tests / linter errors caused by the config change? How to resolve?
dherges
force-pushed
the
feat/kaniko-imagepullsecret
branch
from
d36ff67 to
8f18c02
Compare
|
Hello @JeromeJu I rebased the branch to latest main branch. Could you take a look? |
dherges
force-pushed
the
feat/kaniko-imagepullsecret
branch
from
8f18c02 to
c6afa55
Compare
|
rebased to resolve conflicts |
dherges
force-pushed
the
feat/kaniko-imagepullsecret
branch
from
c6afa55 to
a72bcbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: adds config option to address issue #9170
Related: #9170
Merge before/after: before #9191
Description
User facing changes (remove if N/A)
Adds a new config option for pulling kaniko images from private registry
Follow-up Work (remove if N/A)
implementation follows in #9183