fix: update git-sync to v4.2.1 to fix a pulling issue #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #1146 |
nan-yu
force-pushed
the
git-sync-update
branch
from
42d0780 to
4a0cee7
Compare
nan-yu
force-pushed
the
git-sync-update
branch
from
4a0cee7 to
fac1506
Compare
|
/lgtm |
There is a bug in git-sync v4.1.0. When branches in different remotes are out of sync, `git-sync` fetches the commit SHA from the last line, which may not be the latest. This leads to an issue that Config Sync couldn't pull the latest commit from HEAD. The issue was fixed in v4.2.0 by kubernetes/git-sync#845. This commit updates git-sync to v4.2.1 to include the fix. It also bumps the debian-base to latest version for CVE fixes. b/325341042
nan-yu
force-pushed
the
git-sync-update
branch
from
fac1506 to
b1c136b
Compare
|
/lgtm |
tiffanny29631
approved these changes
Feb 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiffanny29631 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 64e8f7e
into
GoogleContainerTools:main
5 of 6 checks passed
nan-yu
added a commit
to nan-yu/kpt-config-sync
that referenced
this pull request
Feb 27, 2024
…rTools#1147) There is a bug in git-sync v4.1.0. When branches in different remotes are out of sync, `git-sync` fetches the commit SHA from the last line, which may not be the latest. This leads to an issue that Config Sync couldn't pull the latest commit from HEAD. The issue was fixed in v4.2.0 by kubernetes/git-sync#845. This commit updates git-sync to v4.2.1 to include the fix. It also bumps the debian-base to latest version for CVE fixes. b/325341042
google-oss-prow bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
There is a bug in git-sync v4.1.0. When branches in different remotes are out of sync, `git-sync` fetches the commit SHA from the last line, which may not be the latest. This leads to an issue that Config Sync couldn't pull the latest commit from HEAD. The issue was fixed in v4.2.0 by kubernetes/git-sync#845. This commit updates git-sync to v4.2.1 to include the fix. It also bumps the debian-base to latest version for CVE fixes. b/325341042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in git-sync v4.1.0. When branches in different remotes
are out of sync,
git-syncfetches the commit SHA from the last line,which may not be the latest. This leads to an issue that Config Sync
couldn't pull the latest commit from HEAD.
The issue was fixed in v4.2.0 by
kubernetes/git-sync#845.
This commit updates git-sync to v4.2.1 to include the fix.
It also bumps the debian-base to latest version for CVE fixes.
b/325341042