-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for RegistryClient.pullManifest() #2555
Conversation
…into louis-fixnpeexception Merging #2537 fix
…into pullmanifest Update local branch
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
Also, let's have another Note that you can find these - |
@chanseokoh Should I write the pullManifest test that uses a manifest list(instead of a manifest file) as a separate test function? |
Yes, in a separate test. |
…into pullmanifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good. We're right on track.
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait for the manifest list test.
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Minor comments.
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryClientTest.java
Show resolved
Hide resolved
I still see some of my nit comments have not been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge when you think ready.
Part of #1808