docs: default values #986
docs: default values #986
Conversation
asthamohta
requested review from
darshan-sj and
VardhanThigle
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
=======================================
Coverage 46.72% 46.72%
=======================================
Files 169 169
Lines 22810 22810
Branches 559 559
=======================================
Hits 10659 10659
Misses 11546 11546
Partials 605 605
|
| @@ -32,6 +32,7 @@ Spanner migration tool scans through the generated spanner schema and notifies t | |||
| ## Errors | |||
|
|
|||
| - Detection of unsupported check constraints in spanner. | |||
| - Detection of unsupported default values in spanner. | |||
There was a problem hiding this comment.
Will this be a warning or an error? Are we stopping the user from proceeding with the migration in case a default value isn't supported?
| While Spanner supports default values, Spanner migration tool currently does not support translating source `DEFAULT` constraints to Spanner `DEFAULT` constraints. We drop the `DEFAULT` MySQL constraint during conversion. | ||
| It can be manually added to the DDL via an `ALTER TABLE` command. | ||
| Spanner Migration Tool will migrate all valid `DEFAULT` values from MySQL source automatically | ||
| to Spanner and drop invalid `DEFAULT` constraints. |
There was a problem hiding this comment.
we should mention that a warning will be displayed for dropped/invalid DEFAULT constraints. Also I think calling existing default constraints invalid is wrong, we should say that we map 1:1 and in case the syntax is invalid for spanner we drop the constraint
| @@ -28,7 +28,7 @@ Users can view detailed information for a table by selecting it from the **Spann | |||
|
|
|||
| Column tab provides information on the columns that are a part of the selected table. It also provides the option to edit the column wherein a user can modify a column name, delete a column, change the data type of the column, add auto-generation to the column or modify the null property of the column. Once the user is done with required modifications, they can click on **SAVE & CONVERT **and the update would reflect in the session file and across all the components in the database. | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
can you please add an attachment in the PR description of how this page looks in the new png?
| @@ -28,7 +28,7 @@ Users can view detailed information for a table by selecting it from the **Spann | |||
|
|
|||
| Column tab provides information on the columns that are a part of the selected table. It also provides the option to edit the column wherein a user can modify a column name, delete a column, change the data type of the column, add auto-generation to the column or modify the null property of the column. Once the user is done with required modifications, they can click on **SAVE & CONVERT **and the update would reflect in the session file and across all the components in the database. | |||
There was a problem hiding this comment.
This section needs to be updated with latest screenshots apart from the one updated and details around modifying/adding default values: https://googlecloudplatform.github.io/spanner-migration-tool/ui/schema-conv/spanner-draft.html#column
No description provided.