Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displaying Default Values #887

Open
wants to merge 1 commit into
base: feature/default-value
Choose a base branch
from
Open

Displaying Default Values #887

wants to merge 1 commit into from

Conversation

NirnayaSindhuSuthari
Copy link
Contributor

@NirnayaSindhuSuthari NirnayaSindhuSuthari commented Jul 25, 2024 •
edited
Loading

  • Default Value column is added after Nullable column for both source and spanner databases.
  • For long default value (which has many characters) , the value is trimmed and only some part is displayed. User can see the full default value in SQL tab.
  • Image showing Default Value column for MySQL source database
    image
  • Image showing Default Value column for Spanner database
    image
  • Image of trimmed Long Default Value in Default Value column
    image

@NirnayaSindhuSuthari NirnayaSindhuSuthari requested a review from a team as a code owner July 25, 2024 01:42
@NirnayaSindhuSuthari NirnayaSindhuSuthari requested review from VardhanThigle and aksharauke and removed request for a team July 25, 2024 01:42
darshan-sj
darshan-sj reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post screenshots in the description.

ui/src/app/components/object-detail/object-detail.component.scss Show resolved Hide resolved
asthamohta
asthamohta approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asthamohta
asthamohta requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix UI changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshan-sj darshan-sj darshan-sj left review comments

@asthamohta asthamohta asthamohta requested changes

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@aksharauke aksharauke Awaiting requested review from aksharauke aksharauke is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NirnayaSindhuSuthari @darshan-sj @asthamohta