-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tpu): add tpu queued resources time bound sample. #9617
Open
TetyanaYahodska
wants to merge
18
commits into
main
Choose a base branch
from
tpu_queued_resources_time_bound
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests
product-auto-label
bot
added
api: tpu
Issues related to the Cloud TPU API.
samples
Issues that are directly related to samples.
labels
Oct 30, 2024
TetyanaYahodska
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Oct 30, 2024
TetyanaYahodska
requested review from
yoshi-approver and
a team
as code owners
October 30, 2024 13:04
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 4, 2024
TetyanaYahodska
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: tpu
Issues related to the Cloud TPU API.
kokoro:run
Add this label to force Kokoro to re-run the tests.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please review this PR after #9613
Documentation -> https://cloud.google.com/tpu/docs/queued-resources
This example describes how to create a queuedResource with a specific time-bound configuration. Some configurations are commented out to avoid creating many similar samples.
NodeJs sample -> GoogleCloudPlatform/nodejs-docs-samples#3907
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only