Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore unknown fields when unmarshaling GCS Events #4570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kramarz
Copy link

@kramarz kramarz commented Nov 13, 2024

GCS in currently adding a new field and that would break any code that is based on these samples.

Description

internal: b/378854932

GCS in currently adding a new field and that would break any code that
is based on these samples.
@kramarz kramarz requested review from a team as code owners November 13, 2024 16:12
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 13, 2024
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kramarz thanks for the PR. @telpirion is currently investigating this and we'll provide more info directly.

@telpirion telpirion added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: eventarc Issues related to the Eventarc API. labels Nov 14, 2024
@telpirion telpirion self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the Eventarc API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants