Python/Flask - Replaces gunicorn with uWSGI #463
Conversation
google-cla
bot
added
the
cla: yes
askmeegs
changed the title
| module = contacts:create_app() | ||
| die-on-term = true | ||
|
|
||
| disable-logging=True |
There was a problem hiding this comment.
Note - this logging only refers to the uwsgi access logs, which happen on every request and were noisy. And I couldn't find a way to match them to the user-provided log level, as we do with the flask app logs. So I turned them off for now.
But the Flask logs are intact / unchanged, still respond to log level.
askmeegs
changed the title
|
🚀 PR staged at http://35.226.168.122 |
askmeegs
changed the title
| @@ -5,4 +5,5 @@ disable=F0401, # import loading | |||
| E1101, # function members | |||
| R0801, # duplicate code | |||
| R0903, # public methods | |||
| R0915 # too many statements | |||
| R0915, # too many statements | |||
| R0914 # too many local variables | |||
There was a problem hiding this comment.
Are we using an open source Google style guide for the linter?
If so, we should strongly consider disabling as few rules as possible, else it sorts of defeats the purpose (of the linter).
I'm not too sure about pylint specifically but there should also be a way to disable a certain rule locally, for a tiny chunk of code where the rule just doesn't make sense, while keeping it enabled elsewhere.
Thoughts?
There was a problem hiding this comment.
Filed a follow-up issue for this! #465
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2020 Google LLC | |||
| # Copyright 2021 Google LLC | |||
There was a problem hiding this comment.
General question: do we typically modify the copyright year per-file on-change, or do we try to keep all of them up-to-date as much as possible?
There was a problem hiding this comment.
I try to manually update to the current year anytime I change the file. The dev-kubernetes-manifests have to get manually updated for the new year, before generating the next release
Yes! |
askmeegs
changed the title
|
🚀 PR staged at http://35.226.168.122 |
…501) * Revert "Python/Flask - Replaces gunicorn with uWSGI (#463)" This reverts commit b5b0024. * bump gunicorn and adjust dockerfiles * call locust directly in loadgenerator * remove escapes from entrypoint * update copyright year in touched files Co-authored-by: Megan O'Keefe <[email protected]>
Note - I created an uptime check for my own long-standing deployment of this PR. Before merging, I want to make sure the readiness probe issues don't recur. Given no probe failures, this PR will be safe to merge on Thursday, 3/18
Fixes the ongoing readiness + liveness probe issues for the Python services (#447), which seem to be caused by this gunicorn sockets bug. While the gunicorn bug has been fixed, they haven't put out a release yet, and haven't since 2019. After conferring w/ team, seems best to switch the Flask WSGI server to uWSGI - this doesn't affect the Flask app itself or the Python APIs. Just the server fronting the Flask app.
Changelog
(for each Python service - contacts, userservice, frontend)
CMDin Dockerfile with uwsgi server startup