Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft: Not for review] Changes to use Existing cassandra io for Bulk Cassandra Read #2114

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

VardhanThigle
Copy link
Contributor

@VardhanThigle VardhanThigle commented Jan 6, 2025

Overview

Changes to use Existing CassandraIO for Cassandra Bulk Read.

@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io branch from 7c79275 to 02378ed Compare January 6, 2025 10:07
@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io branch 4 times, most recently from 19833f9 to bea08e7 Compare January 6, 2025 11:17
@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io branch from bea08e7 to 33a2032 Compare January 6, 2025 11:22
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 93.00699% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (f933ae9) to head (4139891).

Files with missing lines Patch % Lines
...apper/CassandraTableReaderFactoryExistingImpl.java 86.76% 4 Missing and 5 partials ⚠️
...der/io/cassandra/iowrapper/SSLOptionsProvider.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2114      +/-   ##
============================================
+ Coverage     46.62%   54.93%   +8.31%     
+ Complexity     3953     1603    -2350     
============================================
  Files           867      406     -461     
  Lines         51567    21864   -29703     
  Branches       5399     2161    -3238     
============================================
- Hits          24043    12011   -12032     
+ Misses        25808     9151   -16657     
+ Partials       1716      702    -1014     
Components Coverage Δ
spanner-templates 70.36% <93.00%> (+1.73%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 77.51% <ø> (+0.02%) ⬆️
spanner-live-reverse-replication 78.45% <ø> (+0.02%) ⬆️
spanner-bulk-migration 87.79% <93.00%> (+0.12%) ⬆️
Files with missing lines Coverage Δ
...ader/io/cassandra/iowrapper/CassandraDefaults.java 100.00% <100.00%> (ø)
...cassandra/iowrapper/CassandraIOWrapperFactory.java 100.00% <100.00%> (ø)
.../cassandra/iowrapper/CassandraIOWrapperHelper.java 100.00% <100.00%> (ø)
...der/io/cassandra/iowrapper/CassandraIoWrapper.java 100.00% <100.00%> (ø)
...a/rowmapper/CassandraSourceRowMapperFactoryFn.java 100.00% <100.00%> (ø)
...der/io/cassandra/iowrapper/SSLOptionsProvider.java 80.00% <80.00%> (ø)
...apper/CassandraTableReaderFactoryExistingImpl.java 86.76% <86.76%> (ø)

... and 484 files with indirect coverage changes

@VardhanThigle VardhanThigle marked this pull request as ready for review January 6, 2025 11:37
@VardhanThigle VardhanThigle requested a review from a team as a code owner January 6, 2025 11:37
@VardhanThigle VardhanThigle force-pushed the existing-cassandra-io branch 2 times, most recently from a010ea3 to ad50525 Compare January 9, 2025 11:27
@VardhanThigle VardhanThigle changed the title Changes to use Existing cassandra io for Bulk Cassandra Read [Draft: Not for review] Changes to use Existing cassandra io for Bulk Cassandra Read Jan 13, 2025
@VardhanThigle VardhanThigle marked this pull request as draft January 13, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant