Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra io fork #2093

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VardhanThigle
Copy link
Contributor

@VardhanThigle VardhanThigle commented Dec 31, 2024

Changes to make a local fork of Cassandra IO.

  1. Changes to make a local fork of Cassandra IO and get it to build in Maven env and successfully run UT.
  2. The fork is needed to incorporating a waitOn signal in the CassandraIO's PTransform.The actual changes to add WaitOn will be taken up in a following PR.
  3. All the forked class names are prepended with Local following the pattern already followed for SpannerIO.
  4. The only change (apart from renaming) is in the CassandraIOTest UT file, which is necessary to make the UT work on newer versions of Java (please refer to the detailed change note in the code)

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 71.31148% with 140 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (2caf29c) to head (5e0babe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/beam/sdk/io/localcassandra/LocalCassandraIO.java 60.07% 69 Missing and 42 partials ⚠️
...eam/sdk/io/localcassandra/LocalSplitGenerator.java 82.89% 4 Missing and 9 partials ⚠️
...che/beam/sdk/io/localcassandra/LocalRingRange.java 47.82% 10 Missing and 2 partials ⚠️
.../sdk/io/localcassandra/LocalConnectionManager.java 90.90% 1 Missing and 2 partials ⚠️
...ocalcassandra/LocalDefaultObjectMapperFactory.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2093      +/-   ##
============================================
+ Coverage     46.35%   54.64%   +8.28%     
+ Complexity     3931     1627    -2304     
============================================
  Files           862      403     -459     
  Lines         51340    21947   -29393     
  Branches       5394     2241    -3153     
============================================
- Hits          23801    11993   -11808     
+ Misses        25826     9206   -16620     
+ Partials       1713      748     -965     
Components Coverage Δ
spanner-templates 69.71% <70.36%> (+1.46%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.67% <ø> (ø)
spanner-live-reverse-replication 77.93% <ø> (ø)
spanner-bulk-migration 86.22% <70.36%> (-1.09%) ⬇️
Files with missing lines Coverage Δ
.../cassandra/mappings/CassandraMappingsProvider.java 98.00% <ø> (ø)
.../cassandra/rowmapper/CassandraSourceRowMapper.java 100.00% <100.00%> (ø)
.../io/cassandra/schema/CassandraSchemaDiscovery.java 98.24% <ø> (ø)
.../localcassandra/LocalDefaultObjectLocalMapper.java 100.00% <100.00%> (ø)
...apache/beam/sdk/io/localcassandra/LocalReadFn.java 100.00% <100.00%> (ø)
...ocalcassandra/LocalDefaultObjectMapperFactory.java 83.33% <83.33%> (ø)
.../sdk/io/localcassandra/LocalConnectionManager.java 90.90% <90.90%> (ø)
...che/beam/sdk/io/localcassandra/LocalRingRange.java 47.82% <47.82%> (ø)
...eam/sdk/io/localcassandra/LocalSplitGenerator.java 82.89% <82.89%> (ø)
...e/beam/sdk/io/localcassandra/LocalCassandraIO.java 60.07% <60.07%> (ø)

... and 486 files with indirect coverage changes

@VardhanThigle VardhanThigle marked this pull request as ready for review December 31, 2024 11:47
@VardhanThigle VardhanThigle requested a review from a team as a code owner December 31, 2024 11:47
@VardhanThigle VardhanThigle changed the title [Draft-Not-For-Review] Cassandra io fork Cassandra io fork Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant