-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Linting as a part of CI #393
Added Linting as a part of CI #393
Conversation
@hoch please review the PR, at your convenience. Thanks :) |
hi @hoch. Any update on this? |
Hi @hoch, Any update on this PR? |
Apologies. I am currently swamped by urgent tasks at work. I'll ask around if other team members are able to review this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tarunsinghofficial, thank you for raising and working on this issue. I'll take on the review since Hongchan has been overloaded recently.
The overall approach looks good to me. I left some comments, please take a look and let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looking even better! Just a few more comments.
…lint:eslint from package.json, and remove 'push' trigger from lint workflow
Thanks for the feedback @mjwilson-google. Done with all the changes and is ready to 🚀 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for your work on this.
Overview
This PR introduces and fixes #392 for automated linting to our Continuous Integration (CI) pipeline. It aims to ensure consistent code style and catch potential errors early in the development process.
Changes
.github/workflows/ci.yml
.prettierignore
to ignore some package managersImplementation Details
The new CI workflow does the following:
Notes
Please review and let me know if any changes or additions are needed.