Vibrate the device on game lost #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosamari
changed the title
|
I'm going to add vibrate on-off preference in settings menu as well. |
kosamari
changed the title
kosamari
requested review from
jakearchibald and
surma
and removed request for
jakearchibald
|
this partially addresses #453 |
surma
approved these changes
May 13, 2019
| @@ -186,6 +187,9 @@ export default class Game extends Component<Props, State> { | |||
| this._tryAgainBtn | |||
| ) { | |||
| this._tryAgainBtn.focus(); | |||
| if (this.props.vibrate) { | |||
| window.navigator.vibrate(300); | |||
There was a problem hiding this comment.
Omit window and move 300 to the constants file.
There was a problem hiding this comment.
@surma did you mean constants file in util or just const within the file??
| @@ -47,6 +47,7 @@ export interface Props { | |||
| toRevealTotal: number; | |||
| useMotion: boolean; | |||
| bestTime?: number; | |||
| vibrate: boolean; | |||
There was a problem hiding this comment.
I’d call this useVibration or something in that vein.
| @@ -35,6 +35,8 @@ interface Props { | |||
| disableAnimationBtn: boolean; | |||
| texturePromise: Promise<any>; | |||
| supportsSufficientWebGL: boolean; | |||
| vibrate: boolean; | |||
| @@ -98,6 +98,7 @@ interface State { | |||
| motionPreference: boolean; | |||
| gameInPlay: boolean; | |||
| allowIntroAnim: boolean; | |||
| vibrationPreference: boolean; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/hashseed/status/1127875233531289600