feat: implement user context subscriptions #3039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/user-context-subscription
branch
3 times, most recently
from
224ef9b to
9f90bbb
Compare
2 tasks
OrKoN
force-pushed
the
orkon/user-context-subscription
branch
from
53c7ba5 to
dde1a3b
Compare
OrKoN
force-pushed
the
orkon/user-context-subscription
branch
from
dde1a3b to
085ab17
Compare
| } | ||
| // user context subscription. | ||
| if (subscription.userContextIds.size !== 0) { | ||
| if (!contextId) { |
There was a problem hiding this comment.
nit: contextId became opaque. Consider renaming to browsingContextId.
| @@ -69,6 +69,35 @@ async def test_subscribeWithoutContext_subscribesToEventsInAllContexts( | |||
| assert resp["params"]["context"] == context_id | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
| async def test_subscribeUserContext(websocket, context_id, html): | |||
There was a problem hiding this comment.
it would be nice to have a test for a cusom user context as well. However we can delegate it to WPT tests, up to you
sadym-chromium
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2983