Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite unit tests for SubscriptionManager #2967

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 10, 2025

  • only check channels when the order of channels is relevant.
  • use isSubscribeTo for the rest of tests

@OrKoN OrKoN force-pushed the orkon/rewrite-unit-tests branch from 8507f27 to a0d3e2d Compare January 10, 2025 10:24
@OrKoN OrKoN requested a review from sadym-chromium January 10, 2025 10:25
@OrKoN OrKoN force-pushed the orkon/rewrite-unit-tests branch from a0d3e2d to db18e3c Compare January 10, 2025 10:37
@OrKoN OrKoN force-pushed the orkon/rewrite-unit-tests branch from db18e3c to 8f093aa Compare January 10, 2025 11:20
@OrKoN OrKoN merged commit 684ec40 into main Jan 10, 2025
50 checks passed
@OrKoN OrKoN deleted the orkon/rewrite-unit-tests branch January 10, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants