#411 fix search sync #415
Open
#411 fix search sync #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into develop # Conflicts: # src/controllers/connector/Leaders.js # src/services/Connector.js
bacher
requested changes
Sep 4, 2019
src/services/SearchSync.js
Outdated
| @@ -176,10 +176,23 @@ class SearchSync extends BasicService { | |||
| } | |||
| } | |||
|
|
|||
| async _getDocsToSync(model, from = new Date(null)) { | |||
| return await await model.find({ | |||
| async _getDocsToSync({ model, from = new Date(null), maxDocs = 200, sequenceKey }) { | |||
There was a problem hiding this comment.
Очень странная запись new Date(null), если нужна начала эпохи то лучше написать new Date(0) потому что new Date(null) как раз вернет начало эпохи.
Просто когда видишь в коде new Date(null) то кажется что будет вообще Invalid Date.
Я понимаю, что это было до этого PR, но если можно то лучше сейчас поправить.
src/services/SearchSync.js
Outdated
| } | ||
| } | ||
|
|
||
| await Promise.all(syncPromises); |
There was a problem hiding this comment.
Всю эту конструкцию с Promise.all можно записать в более компактном и как я считаю понятном виде (без лишних переменных):
if (dataToSync.length > 0) {
await Promise.all(dataToSync.map(data => this._syncDoc(model, data)));
}Кода меньше, нет лишних push и массива.
bacher
approved these changes
Sep 4, 2019
beautyfree
approved these changes
Sep 4, 2019
b1acksun
approved these changes
Sep 4, 2019
bacher
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.