Crypto stream #35
Open
Crypto stream #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename all functions - Add tests for all functions - Change return types (removed exit status) - Rename Keygen to KeyGen - Fix issues with zero-length data
- Use constants instead of getter functions - Create types for key and nonce - Rename function to match golang.org/crypto naming
- Add message length checks - Remove Salsa208 as it is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps all the
crypto_streamfunctions (for libsodium 1.0.15) in the following packages:crypto_streamcrypto/stream/chacha20crypto/stream/chacha20ietfcrypto/stream/salsa2012crypto/stream/salsa20crypto/stream/xchacha20crypto/stream/xsalsa20For performing the size checks from libsodium 1.0.14 the
support.CheckSizeMaxfunction is added.All code includes tests with 100% coverage and is linted with
golint.