Bug799430 Split auto complete bug #2031
Conversation
No tool used, I just find it easier to read the source files if there is a consistent use of spaces and just changed it visually. |
Using a tool is easier. We've used astyle in the past, usually with args Since you did it by eye, a question: Why do you like a space between a function name and its opening parenthesis but not between a preprocessor macro and its opening parenthesis? |
|
Go ahead and merge when you're ready. |
When using split autocomplete, the transfer account was not being set due to a change in xaccSplitGetSharePrice in 4.10 that return 0 instead of 1 when there is no price so reflect this change in the following function gnc_find_split_in_trans_by_memo
|
Will install
If I remember correctly, in the early days when I was submitting patches on bug reports it was suggested to do it that way. |
code-gnucash-org
temporarily deployed
to
github-pages
GitHub Actions
Inactive
I think the first commit fixes the issue that if you try to auto complete a split using the memo text from a split that has no values it fails to fill in the transfer account. This has stemmed from a change in the return value of xaccSplitSetSharePrice in version 4.10
Just looking for confirmation of change before I push this.
The second commit is just realigning the source file after the change to cpp.