[dialog-price-edit-db.cpp] Copy the latest price when creating a new entry from a commodity selection #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jralls
reviewed
Apr 30, 2024
There's nothing here that empties the price. Was it your intention to? Might it make sense to change the date to today instead of defaulting to the last price's date? |
See my reply in the discussion thread. It will be zeroed. |
…entry from a commodity selection When a price entry is selected, it's contents get copied 1:1 to the newly created price to facilitate faster entry based on existing values (e.g. the type). When selecting a commodity instead, the user is presented with an empty price entry where only the commodity is set. IMO the user ends up with the same values (except the price of course) as the latest entry. So we check whether we have a (latest) entry and use that as the template, so that e.g. the type gets copied, too. This spares the user some clicks.
boomer41
force-pushed
the
feature/pricedb-add-clone-from-latest
branch
from
11a5082
to
c10af4e
Compare
|
Thanks! |
You may have misspelled my name in the merge commit message, but all good :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a price entry is selected, it's contents get copied 1:1 to the newly created price to facilitate faster entry based on existing values (e.g. the type).
When selecting a commodity instead, the user is presented with an empty price entry where only the commodity is set.
IMO the user ends up with the same values (except the price of course) as the latest entry.
So we check whether we have a (latest) entry and use that as the template,
so that e.g. the type gets copied, too.
This spares the user some clicks.