Fix first-day-of-week detexion in dense calendar (Upcoming Transactions)

[nabijaczleweli]

GnuCash depends on GTK3, and not GTK2. Thus:

$ gettext -d gtk20 calendar:week_start:0; echo
calendar:week_start:0
$ LC_LANG=pl_PL.UTF-8 gettext -d gtk20 calendar:week_start:0; echo
calendar:week_start:0

$ gettext -d gtk30 calendar:week_start:0; echo
calendar:week_start:1
$ LC_LANG=pl_PL.UTF-8 gettext -d gtk30 calendar:week_start:0; echo
calendar:week_start:1

because the "gtk20" catalog, provided by GTK2, doesn't exist.

Before:

After:

This corresponds to https://bugs.gnucash.org/show_bug.cgi?id=797623 and https://bugs.gnucash.org/show_bug.cgi?id=752395

[christopherlam]

Would be better to use

gnucash/libgnucash/engine/gnc-date.cpp

Line 194 in cab6173

gnc_start_of_week (void)

which returns 1..7 for Sun..Sat

[nabijaczleweli]

Indeed; applied.

[Bob-IT]

I agree that this was an over site from gtk2 to 3 but curious on how have you tested this, what OS's.

[nabijaczleweli]

As evident from the top-level post, I just ran it and looked at the calendar. bookworm.

[nabijaczleweli]

3-week bump

[christopherlam]

It's a simple fix which looks inadequate... Do you think it's feasible to support start of week on any of the weekdays?

[Bob-IT]

It's a simple fix which looks inadequate... Do you think it's feasible to support start of week on any of the weekdays?

@christopherlam I did look at this a while back that did allow any start day but required some more testing and refinement.
I will dig it out and create a PR for comment next week.

[jralls]

It should be a localization setting. ICU has getFirstDayOfWeek. I found hints that nl_langinfo has added it in the last couple of years but it doesn't show up in the Linux docs.

[nabijaczleweli]

ftr gnucash already uses getFirstDayOfWeek() for this

[Bob-IT]

I have added #PR1935 which was what I was working on last year.

[jralls]

Closing in favor of #1935.