Bug 798995 - Keystrokes ignored during ledger entry

[Bob-IT]

Some themes add additional pixels to list rows and dialogs, in this case with 'TraditionalOK' 2 pixels are added to each entry in the list and 2 to the popup. This make the calculation for the pop up height wrong and so when compared to the allocation height it is different so tries to resolve by re-popping the list and this causes an endless loop.

To fix this, use the calculated height which works for Adwaita but if this is different to the popup allocation height use that.

I have tested this on the reported OS, Fedora38 with the reported 'TraditionalOK' theme and also on an Xfce VM with the 'Clearlooks-Phenix' theme. Also built and tested on Windows and all seems to be OK.

[bparees]

can confirm, this appears to resolve the issue i was seeing when using TraditionalOk with Mate on Fedora38

thank you!

[Bob-IT]

I have added calculating the popup height to gnucash-item-list as the same calculation was being done in two places and added calling it from the else condition.

Is this partly to figure out how big a window to ask for or otherwise set height before the popup is realized and has an allocation?

The calculation of height is correct for Adwaita but for other themes it may be correct or an approximation. The height is used to decide on the placement of the popup which is based on the greater space above or below the current position. Setting the height is needed when the list is large to restrict the popup to the register size.

I am not sure I can see a better way but will have a think.

[ipilcher]

This also fixes the issue for me. (Seen with the Breeze theme under KDE/Plasma/X11.)

[jralls]

Thanks!