Iter to stl #1751
Closed
Iter to stl #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter() - GncTreeContainer::append() creates a new GncTreeIter in the model - GncTreeIter::get_gtk_tree_iter() returns the GtkTreeIter being held - GncTreeIter also inherits from std::iterator<std::forward_iterator_tag> so that std::find_if can work --- This creates two (potentially confusing) methods to retrieve the GtkTreeIter from these classes: 1. GncTreeData::get_iter() returns &m_iter 2. GncTreeIter::get_gtk_tree_iter() also returns &m_iter It would seem for (auto iter : container) returns a GncTreeData whose GtkTreeIter is accessed via iter.get_iter(). However `iter = std::find_if(container.begin(), container.end(), predicate)` returns a GncTreeIter whose GtkTreeIter is accessed via iter.get_gtk_tree_iter().
christopherlam
force-pushed
the
iter-to-stl
branch
from
537f8db
to
63f9daf
Compare
|
Closed because although this compiles, it segfaults when running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More iter changes.
std::find_ifand friends, theGncTreeIterseems to need iterator traits inherited fromstd::iterator. See the class definitionGncTreeContaineradds anappend()methods which adds a newGtkTreeIterand returns itsGncTreeIter.GncTreeIteradds aget_gtk_tree_iterto return theGtkTreeIterto be useful whenfind_ifreturns theGncTreeIter. This creates another method to access the GtkTreeIter; one from the GncTreeIter and another from GncTreeData. The benefit is this allows:instead of the uglier
std::find_ifuse inimport-match-picker.cpp.