Implement support for !Type:Prices QIF records. #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM... |
jralls
requested changes
Sep 10, 2023
Comment on lines
1394
to
1397
| (set-tm:hour tm 11) | ||
| (set-tm:min tm 0) | ||
| (set-tm:sec tm 0) |
There was a problem hiding this comment.
We use 10:59:00Z for neutral time because 11:00:00Z is 00:00:00 the next day in New Zealand summer time.
It is 10x faster against a large dataset. Insight from Christopher Lam.
Found a live Quicken record with an empty price.
The price import will now throw warnings if there are invalid prices. The previous logic would 'auto-next' in this case, only holding if the parse-file phase threw warnings. This change insures that these warnings are seen.
Including a few deliberate errors.
Also use a more standard numberic parser instead of an ad-hoc string parser. Code written by Christopher Lam.
The expected results changed with commit 80f7e60f49. At the same time, improve readability of test results by assigning a tag and ordering expected vs actual correctly.
jralls
approved these changes
Sep 10, 2023
|
I took care of neutral time and merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.