Remove Windows ifdef for VK_DECIMAL

There was Windows specific ifdef code for the setting of the event keyval property to GDK_KEY_KP_Decimal in five locations which is now redundant. The requirement for this was fixed in Gtk version 3.17.2 https://gitlab.gnome.org/GNOME/gtk/-/commit/578043f97e891e423648c9f70ddf1d185f4615c4
Gnucash · Sep 12, 2024 · 9dee343 · 9dee343
1 parent 4314bf1
commit 9dee343
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 28 deletions.
diff --git a/gnucash/gnome-utils/gnc-amount-edit.c b/gnucash/gnome-utils/gnc-amount-edit.c
@@ -278,11 +278,6 @@ gnc_amount_edit_key_press (GtkWidget *widget, GdkEventKey *event, gpointer user_
         gtk_widget_set_tooltip_text (GTK_WIDGET(gae->image), NULL);
     }
 
-#ifdef G_OS_WIN32
-    /* gdk never sends GDK_KEY_KP_Decimal on win32. See #486658 */
-    if (event->hardware_keycode == VK_DECIMAL)
-        event->keyval = GDK_KEY_KP_Decimal;
-#endif
     if (event->keyval == GDK_KEY_KP_Decimal)
     {
         gchar *decimal;

diff --git a/gnucash/gnome/gnc-budget-view.c b/gnucash/gnome/gnc-budget-view.c
@@ -773,12 +773,6 @@ gbv_key_press_cb (GtkWidget *widget, GdkEventKey *event, gpointer user_data)
     if (event->type != GDK_KEY_PRESS || !priv->temp_cr)
         return FALSE;
 
-#ifdef G_OS_WIN32
-    /* gdk never sends GDK_KEY_KP_Decimal on win32. See #486658 */
-    if (event->hardware_keycode == VK_DECIMAL)
-        event->keyval = GDK_KEY_KP_Decimal;
-#endif
-
     switch (event->keyval)
     {
     case GDK_KEY_KP_Decimal:

diff --git a/gnucash/register/register-gnome/formulacell-gnome.c b/gnucash/register/register-gnome/formulacell-gnome.c
@@ -71,11 +71,7 @@ gnc_formula_cell_direct_update( BasicCell *bcell,
      * this after fixing a bug where one copy was kept up to date, and the
      * other not.  So, fix this.
      */
-#ifdef G_OS_WIN32
-    /* gdk never sends GDK_KEY_KP_Decimal on win32. See #486658 */
-    if (event->hardware_keycode == VK_DECIMAL)
-        event->keyval = GDK_KEY_KP_Decimal;
-#endif
+
     switch (event->keyval)
     {
     case GDK_KEY_Return:

diff --git a/gnucash/register/register-gnome/gnucash-sheet.c b/gnucash/register/register-gnome/gnucash-sheet.c
@@ -1876,14 +1876,8 @@ gnucash_sheet_key_press_event (GtkWidget *widget, GdkEventKey *event)
     sheet = GNUCASH_SHEET(widget);
     /* bug#60582 comment#27 2
            save shift state to enable <shift minus> and <shift equal>
-       bug#618434
-           save keyval to handle GDK_KEY_KP_Decimal event
      */
-#ifdef G_OS_WIN32
-    /* gdk never sends GDK_KEY_KP_Decimal on win32. See #486658 */
-    if (event->hardware_keycode == VK_DECIMAL)
-        event->keyval = GDK_KEY_KP_Decimal;
-#endif
+
     sheet->shift_state = event->state & GDK_SHIFT_MASK;
     sheet->keyval_state =
         (event->keyval == GDK_KEY_KP_Decimal) ? GDK_KEY_KP_Decimal : 0;

diff --git a/gnucash/register/register-gnome/pricecell-gnome.c b/gnucash/register/register-gnome/pricecell-gnome.c
@@ -60,11 +60,6 @@ gnc_price_cell_direct_update (BasicCell *bcell,
 
     is_return = FALSE;
 
-#ifdef G_OS_WIN32
-    /* gdk never sends GDK_KEY_KP_Decimal on win32. See #486658 */
-    if (event->hardware_keycode == VK_DECIMAL)
-        event->keyval = GDK_KEY_KP_Decimal;
-#endif
     switch (event->keyval)
     {
     case GDK_KEY_Return: