-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2) Add clean-extra target #310
Open
jralls
wants to merge
12
commits into
Gnucash:stable
Choose a base branch
from
usamimikamen-sk:clean-extra3
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepared variables for build directory transition. Changed build directory creation timing. Fixed dependency.
Added missing OASIS xslt icons into xsl/images. Put latest GnuCash-specific icons into xsl/icons. Removed stylesheets/. Changed CMake files related new directory structure. Changed ${BUILDDIR} to ${CMAKE_CURRENT_BINARY_DIR}/${fmt} for CHM, PDF, and EPUB target.
Removed xsl/1.79.2/ completely. Removed unused customization files.
Fix target install for each format. Clean up unused variables.
FO and HTML have different formats, so you need to customize them appropriately depending on how docbook-xsl is written. Rewrote titlepage and variablelist for each format.
* US letter for C, * A4 for other languages. ISO A4 paper size is used worldwide but letter and legal size are mainly used in the US. Therefore paper size is set above. This setting should be moved CMake option in the future.
…pectively. CHM format uses traditional Windows codepages, not Unicode. Therefore traditional character code should be applied for the HTML and TOC.
CMake's clean feature isn't enough to remove some generated files. Therefore, add clean-extra target which will delete unnecessary files that clean left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate #236
CMake's clean feature isn't enough to remove some generated files.
For example, if you run "make html" and "make clean, generated html files and figures are left in the ${CMAKE_BINARY_DIR}.
Therefore, add clean-extra target which will delete unnecessary files that clean left.