This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Preventing DOM operations on null nodes #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidkpiano, |
legomushroom
reviewed
Jul 7, 2017
src/index.scss
Outdated
| animation: glimpse-ajax-row-enter .3s ease-out !important; | ||
| border: none !important; | ||
| padding: 0 !important; | ||
| margin: 0 !important; |
There was a problem hiding this comment.
Why is this change, I thought we have had it already?
There was a problem hiding this comment.
Err I don't know. I'll undo
There was a problem hiding this comment.
I think this should be fine unless git branches hadn't messed up, this is my main concern.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some general safeguards for DOM nodes that might not exist yet, due to rendering being blocked or something related to that (see #155).
This solution is basically a patch, and will be more robustly fixed once we have an actual framework in place (React/Preact, etc).