Fix error for documents without ListParagraph style #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combining the two still produces ugly results, since in Word a paragraph cannot have a "List Paragraph" and "Blockquote" style at the same time. However it no longer throws an error. Fixes GhostManager#516
Also adds checking in a few other places where styles are assigned. In my experience, deleting the list paragraph style will also delete the numberings XML document entirely, which python-docx cannot recreate. This patch also checks for that and shows the user a more friendly error message. Fixes GhostManager#499
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 91.95% 91.96%
=======================================
Files 314 314
Lines 18158 18158
=======================================
+ Hits 16698 16699 +1
+ Misses 1460 1459 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds checking in a few other places where styles are assigned.
In my experience, deleting the list paragraph style will also delete the
numberings XML document entirely, which python-docx cannot recreate.
This patch also checks for that and shows the user a more friendly error
message.
Fixes #499