Fix error message from linting a docx file with invalid syntax #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_undeclared_template_variables` processes the template but wasn't wrapped in `map_jinja2_render_errors`, so syntax errors weren't being caught properly and failing with a generic failure. This patch fixes it to throw correctly and show the error to the user.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 310 310
Lines 18102 18102
=======================================
Hits 16645 16645
Misses 1457 1457 ☔ View full report in Codecov by Sentry. |
chrismaddalena
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_undeclared_template_variablesprocesses the template but wasn't wrapped inmap_jinja2_render_errors, so syntax errors weren't being caught properly and failing with a generic failure. This patch fixes it to throw correctly and show the error to the user.