Release: v4.1 #411
Merged
Release: v4.1 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows administrators to define additional "extra fields"
via the admin API to include additional deployment-specific data with
ghostwriter models. The data is available via the UI as well as in
report templates.
Define the extra fields by going to the Admin Panel, then the "Extra
Field Configurations" page, then selecting the relevant model. After
adding custom fields, they will be visible in detail and edit pages,
and exposed to the template engine via
`{{ <instance>.extra_fields.<internal_name> }}`.
This patch only adds extra fields support to the Project model, as a
starting point, but the relevant code is extensible to other models.
Internally, this is implemented as two new models: `ExtraFieldModel`,
which corresponds to each Django model and is installed via a fixture,
and `ExtraFieldSpec`, which defines and configures the fields. The
actual data for the extra fields is stored in a `JSONField` on the
relevant model. The patch includes form fields, form widgets, and
django-rest-api serializers that query the `ExtraFieldSpec` and
produces sub fields and widgets based on the declarations.
Fields will show up as columns in the opslog table.
These work like findings, but are more generic and slimmed down. For example, they can be used to describe positive aspects of the system under test. This patch adds the model and CRUD operations on the observations - linking to reports is not yet added.
The code used `DocxTemplate.undeclared_template_variables` after rendering, which will try to look for undefined variables using the rendered document as a template.
Based on code from `jinja2.make_logging_undefined`, detect usage of `Undefined` while rendering the linting test data and report it during linting.
GW was opening the file in the archive export location and passing it to the FileField, which then reads the file path off of it and tries to use it as the file. This throws an error if the archive location is absolute or has a ".." component. Instead, pass it in the zip buffer so that Django creates an accessible file the normal way.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 92.37% 91.87% -0.51%
==========================================
Files 261 289 +28
Lines 16439 17688 +1249
==========================================
+ Hits 15186 16250 +1064
- Misses 1253 1438 +185 ☔ View full report in Codecov by Sentry. |
Also make all tag_* arguments keyword-only, to match how they should be used.
Instead of just stripping whitespaces, process the whitespace similar to how a browser would do so. Improves whitespace for things like paragraphs in blockquotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
[4.1] - 3 April 2024
Added
{{ client.name }}to insert the client's name into a formatted text field{{ client.name|upper }}to make the client's name uppercase)getExtraFieldSpecquery to the GraphQL API that returns the extra field specification for a modelhostnameconfiguration option to the General Settings in the admin panelChanged
Deprecated
{{.project_start}}or{{.client}}) are no longer necessary and will be removed in a future release{{.ref }}or{{.caption }}which will continue to be used for captioning and creating cross-references references