Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Log Imports and Evidence Views #383

Merged
merged 24 commits into from
Jan 26, 2024
Merged

Conversation

chrismaddalena
Copy link
Collaborator

[Unreleased] - 25 January 2024

Fixed

  • Fixed an issue with timestamps in the activity log that could cause an error when importing a csv file

Changed

  • Activity log imports and exports now include the entry_identifier field
  • Activity log imports now check for duplicate entries based on the entry_identifier field and update the existing entry instead of creating a new entry

Security

  • Removed the /media location from the Nginx configuration to remove the potential for unauthorized access to uploaded files

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (3e0abf1) 92.32% compared to head (3bf59e7) 92.35%.
Report is 3 commits behind head on master.

❗ Current head 3bf59e7 differs from pull request most recent head e0effd7. Consider uploading reports for the commit e0effd7 to get more accurate results

Files Patch % Lines
ghostwriter/oplog/views.py 63.79% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   92.32%   92.35%   +0.02%     
==========================================
  Files         261      261              
  Lines       16137    16359     +222     
==========================================
+ Hits        14899    15108     +209     
- Misses       1238     1251      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismaddalena chrismaddalena merged commit 476deaa into master Jan 26, 2024
6 checks passed
@chrismaddalena chrismaddalena deleted the hotfix/log-import-fixes branch March 15, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant