Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accordion for evidences section #364

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

therealtoastycat
Copy link
Contributor

Hi @chrismaddalena,

Description of the Change

When many evidences are added to a finding, the finding summary looked a bit messy so I've modified the 'report_detail' template to include an accordion feature, allowing for the collapse and expansion of evidence sections.
In addition, I've made the 'Attach Evidence' button appear even if evidence has already been added to the finding.:

image

Alternate Designs

None

Possible Drawbacks

None observed

Verification Process

Tested on the last release with google chrome.

Release Notes

  • Collapse findings' evidences in accordeon

Cheers,
ToastyCat

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dacc579) 92.27% compared to head (1f84f86) 92.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         255      255           
  Lines       15996    15996           
=======================================
+ Hits        14760    14761    +1     
+ Misses       1236     1235    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismaddalena chrismaddalena self-assigned this Nov 27, 2023
@chrismaddalena
Copy link
Collaborator

Hey @therealtoastycat, this is a great addition. Thanks for submitting it. I'll merge it shortly.

@chrismaddalena
Copy link
Collaborator

@therealtoastycat I pushed a small change that seems to have broken GitHub. The commit bring sup a 500 error and the PR can't be merged. I'll merge this once this gets sorted out on GitHub's side.

@chrismaddalena chrismaddalena merged commit 6bd74d2 into GhostManager:master Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants