Report Observations #358
Closed
Report Observations #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelThirtyTwo
force-pushed
the
positive-observations
branch
from
8a55b60 to
f478b34
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
These work like findings, but are more generic and slimmed down. For example, they can be used to describe positive aspects of the system under test. This patch adds the model and CRUD operations on the observations - linking to reports is not yet added.
ColonelThirtyTwo
force-pushed
the
positive-observations
branch
from
f478b34 to
2976208
Compare
|
Merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal suggestion by Christopher
Description of the Change
This adds "observations", which work like stripped down versions of findings for more flexible uses. Pre-written observations are stored in a library, and can be attached then edited to reports, or can be added to reports ad-hoc. Unlike findings, they don't have a concept of assignment, evidence, scores, or other things - they are just a title and description, though extra fields support may be added soon.
An example use of this is documenting positive findings - things that the system under test did well, or common issues that the system defended against.
Alternate Designs
I also have a branch that adds a positive/negative field to the findings model, however the team decided that it was not the design they had in mind.
Possible Drawbacks
This duplicates quite a bit of code from the findings,
Verification Process
I've tested all added pages and forms, as well as report generation. I've also added unit tests for the pages, copied from the findings tests.
Release Notes