Add User-Agent with the App Data #1192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
requested review from
aleksandar-apostolov,
skydoves and
liviu-timar
liviu-timar
reviewed
Sep 27, 2024
...oid-core/src/main/kotlin/io/getstream/video/android/core/internal/module/ConnectionModule.kt
Show resolved
Hide resolved
aleksandar-apostolov
approved these changes
Sep 27, 2024
...oid-core/src/main/kotlin/io/getstream/video/android/core/internal/module/ConnectionModule.kt
Show resolved
Hide resolved
|
Do not merge it yet, a customer is having an issue with the same implementation on Chat SDK when the app name contains strange characters |
JcMinarro
force-pushed
the
feature/use-app-user-agent
branch
from
09616b9
to
8df6373
Compare
Ok, it is fixed on the last commit |
JcMinarro
force-pushed
the
feature/use-app-user-agent
branch
2 times, most recently
from
f0787f5
to
c2a729d
Compare
JcMinarro
force-pushed
the
feature/use-app-user-agent
branch
from
c2a729d
to
94242b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Include a custom User-Agent to any HTTP Call our SDK does. The User-Agent will looks like:
The same we did on GetStream/stream-chat-android#5415