-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Channel List .hasUnread
filter
#3340
Merged
nuno-vieira
merged 10 commits into
develop
from
add/expose-has-unread-channel-list-filter
Jul 30, 2024
Merged
Add Channel List .hasUnread
filter
#3340
nuno-vieira
merged 10 commits into
develop
from
add/expose-has-unread-channel-list-filter
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
added
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
✅ Feature
An issue or PR related to a feature
labels
Jul 29, 2024
Generated by 🚫 Danger |
SDK Size
|
SDK Performance
|
martinmitrevski
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
SDK Size
|
Quality Gate passedIssues Measures |
laevandus
approved these changes
Jul 30, 2024
testableapple
added
🟢 QAed
A PR that was QAed
and removed
🤞 Ready For QA
A PR that is Ready for QA
labels
Jul 30, 2024
testableapple
approved these changes
Jul 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 Bug
An issue or PR related to a bug
✅ Feature
An issue or PR related to a feature
🟢 QAed
A PR that was QAed
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://stream-io.atlassian.net/browse/PBE-5351
🎯 Goal
.hasUnread
channel list filter option🛠 Implementation
In order to support automatic filtering, I had to add a new property to
ChannelDTO.currentUserUnreadMessagesCount
which is computed fromChannelDTO.reads
. Otherwise, it was not possible to create an NSPredicate out ofChannelDTO.reads
.By adding this property, we can now make the sorting of unreadCount work properly, which was not working before as well.
🎨 Showcase
Usage:
ChannelListQuery(filter: .hasUnread)
Demo:
Unreads.mov
🧪 Manual Testing Notes
Requirements: Use the SwiftUI API Keys. (The
hasUnread
is not working on the default keys)1- Login
2- Tap on filters button (right top corner)
3- Tap on Unread Channels
4- Should see only unread channels and sorted by unread count
☑️ Contributor Checklist