[CI] Comment SDK size on every commit #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
testableapple
force-pushed
the
ci/comment-sdk-size-on-every-commit
branch
from
74ee608 to
252f1b7
Compare
testableapple
commented
Jul 29, 2024
| name: Metrics | ||
| name: SDK Performance |
There was a problem hiding this comment.
That's because on the Actions tab it was not possible to determine where was the Performance and where was the Size metrics.
testableapple
commented
Jul 29, 2024
Comment on lines
-488
to
-495
| if sh('git status -s', log: false).to_s.empty? | ||
| pr_comment_required = false | ||
| UI.important('No changes in performance benchmarks. Skipping commit and comment.') | ||
| else | ||
| sh('git add -A') | ||
| sh("git commit -m 'Update #{xcmetrics_path}: #{current_branch}'") | ||
| sh('git push') | ||
| end |
There was a problem hiding this comment.
This is to eliminate the useless branch metrics in the baseline json file. Basically now performance metrics will keep only the benchmark, similar to size metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolve https://stream-io.atlassian.net/browse/PBE-4314
📺 Showcase