Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Show sdk size update on PR #3331

Merged
merged 19 commits into from
Jul 24, 2024
Merged

[CI] Show sdk size update on PR #3331

merged 19 commits into from
Jul 24, 2024

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Jul 24, 2024 •
edited
Loading

🔗 Issue Links

Resolve https://stream-io.atlassian.net/browse/PBE-4314

🎯 Goal

Show SDKs' size update on PR

📺 Showcase

Screenshot 2024-07-24 at 5 56 13 PM

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added 🔧 WIP A PR that is Work in Progress 🤖 CI/CD Any work related to CI/CD labels Jul 24, 2024
@testableapple testableapple requested a review from a team as a code owner July 24, 2024 10:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

4 Errors
🚫 Please use more than one word.
856d9f6
🚫 Please use more than one word.
ad49cbb
🚫 Please use more than one word.
cb71ecc
🚫 Please use more than one word.
030dacb

Generated by 🚫 Danger

laevandus
laevandus previously requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved too quick, CI was failing

@testableapple testableapple marked this pull request as draft July 24, 2024 11:23
@testableapple testableapple marked this pull request as ready for review July 24, 2024 11:23
@GetStream GetStream deleted a comment from Stream-SDK-Bot Jul 24, 2024
@testableapple testableapple marked this pull request as draft July 24, 2024 11:33
@testableapple testableapple marked this pull request as ready for review July 24, 2024 11:33
@GetStream GetStream deleted a comment from Stream-SDK-Bot Jul 24, 2024
@testableapple testableapple marked this pull request as draft July 24, 2024 11:54
@testableapple testableapple marked this pull request as ready for review July 24, 2024 11:54
testableapple
testableapple commented Jul 24, 2024
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
@testableapple testableapple marked this pull request as draft July 24, 2024 12:19
@testableapple testableapple marked this pull request as ready for review July 24, 2024 12:19
@testableapple testableapple requested a review from laevandus July 24, 2024 13:56
@testableapple testableapple removed the 🔧 WIP A PR that is Work in Progress label Jul 24, 2024
nuno-vieira
nuno-vieira reviewed Jul 24, 2024
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
nuno-vieira
nuno-vieira reviewed Jul 24, 2024
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
@testableapple testableapple marked this pull request as draft July 24, 2024 15:22
@testableapple testableapple marked this pull request as ready for review July 24, 2024 15:22
nuno-vieira
nuno-vieira reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking great 👌 Just added a couple more questions and suggestions 👍

fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
@testableapple testableapple marked this pull request as draft July 24, 2024 16:15
@testableapple testableapple marked this pull request as ready for review July 24, 2024 16:15
@testableapple testableapple marked this pull request as draft July 24, 2024 16:16
@testableapple testableapple marked this pull request as ready for review July 24, 2024 16:16
@testableapple testableapple marked this pull request as draft July 24, 2024 16:42
@testableapple testableapple marked this pull request as ready for review July 24, 2024 16:42
@GetStream GetStream deleted a comment from Stream-SDK-Bot Jul 24, 2024
@GetStream GetStream deleted a comment from Stream-SDK-Bot Jul 24, 2024
nuno-vieira
nuno-vieira approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.7MB 6.7MB 0.0MB 🟢
StreamChatUI 4.4MB 4.4MB 0.0MB 🟢

@testableapple testableapple marked this pull request as draft July 24, 2024 17:06
@testableapple testableapple marked this pull request as ready for review July 24, 2024 17:06
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.7MB 6.7MB 0.0MB 🟢
StreamChatUI 4.4MB 4.4MB 0.0MB 🟢

@testableapple testableapple merged commit de9faf4 into develop Jul 24, 2024
1 check passed
@testableapple testableapple deleted the ci/compare-size-across-branches branch July 24, 2024 17:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
141 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@laevandus laevandus Awaiting requested review from laevandus

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testableapple @Stream-SDK-Bot @laevandus @nuno-vieira