-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Background Mapping] Fix Mark as unread #2906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
polqf
changed the title
Fix Mark As Unread in BG
[Background Mapping] Fix Mark as unread
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM codewise ✅ Only spotted one issue while testing (shared on Slack), not sure if it's related to BM. @testableapple should run a QA as well 🙏
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
testableapple
added
🟢 QAed
A PR that was QAed
and removed
🤞 Ready For QA
A PR that is Ready for QA
labels
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Closes https://github.com/GetStream/ios-issues-tracking/issues/652
🎯 Goal
Fix Mark as unread when Background Mapping is enabled
📝 Summary
We need to use the data that the API Request returns to us, instead of waiting for the delegate calls.
The most important thing here is that we cannot use the delegate calls because we cannot know if the update is from a “mark as unread” action or a different thing. If we just update the unread banner on the delegate call, we lose all the context as the channel will be marked as read, and the views would then disappear.
🛠 Implementation
markUnread(from:completion:)
moves from just returning theError
to returning aResult
object with the data.ChannelController.getFirstUnreadMessageId(for:)
is now publicChannel
exposes now a convenience function to get the lastReadMessageId based on a user id (lastReadMessageId(userId:)
)🧪 Manual Testing Notes
Precondition: BG Mapping Enabled
Expected result:
☑️ Contributor Checklist
🎁 Meme