Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Do not mark channel as read for new members #2905

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

polqf
Copy link
Contributor

@polqf polqf commented Nov 21, 2023

🔗 Issue Links

https://github.com/GetStream/ios-issues-tracking/issues/653

🎯 Goal

Stop marking channels as read for new members

📝 Summary

Seems like we were marking the chat history as read for new channel members. This created a situation where on adding a member, all the messages in the history would increase their read count by one.

🛠 Implementation

Stop marking as read for a new member in MemberEventMiddleware

🧪 Manual Testing Notes

  1. Create a group
  2. Send a message
  3. Add a new member

Expected result:

  • Read counts on messages should not increase

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

@polqf polqf requested a review from a team as a code owner November 21, 2023 10:02
@polqf polqf enabled auto-merge (squash) November 21, 2023 10:47
@polqf polqf disabled auto-merge November 22, 2023 14:16
@polqf polqf force-pushed the bugfix/do-not-mark-channel-as-read-for-new-members branch from 8dd34ad to 8107953 Compare November 24, 2023 12:05
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

90.7% 90.7% Coverage
0.1% 0.1% Duplication

@polqf polqf merged commit dbccc6b into develop Nov 24, 2023
17 checks passed
@polqf polqf deleted the bugfix/do-not-mark-channel-as-read-for-new-members branch November 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants