Bugfix: Do not mark channel as read for new members #2905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
https://github.com/GetStream/ios-issues-tracking/issues/653
🎯 Goal
Stop marking channels as read for new members
📝 Summary
Seems like we were marking the chat history as read for new channel members. This created a situation where on adding a member, all the messages in the history would increase their read count by one.
🛠 Implementation
Stop marking as read for a new member in MemberEventMiddleware
🧪 Manual Testing Notes
Expected result:
☑️ Contributor Checklist
🎁 Meme